Alex Orosciuc

Results 18 comments of Alex Orosciuc

@bennothommo welcome :) > the idea of where I would approach this too - capturing the error code and making it available in another method so that the original methods...

> Just to note, this is a breaking change. I'd still like it to work similar to [my comments here](https://github.com/wintercms/winter/issues/315#issuecomment-1955662725), especially since this is a potential data loss pain point....

See https://github.com/wintercms/winter/pull/1226

@mjauvin yes I use `listFilterExtendScopes` on my controller instance. I can imagine why you think it's not "needed". I was even thinking about completely dropping the idea of modifying and...

Because it's two actions, and one action is easier.

@mjauvin both the original `count()` method and `getCountForPagination()` are available in `Illuminate\Database\Query\Builder`, but the main difference is that `count()` is much simpler and I suppose was never meant to be...

> > @lex0r what about `toBase()`? > > `toBase()` will retrieve the data from the database but it will not prepare the associated Eloquent models. If you are not really...

> @lex0r what about `toBase()`? > > Also, unit test for this would be very appreciated. I would expect a unit test that checks for what records are returned based...