lewri

Results 345 comments of lewri

If you have time, add yourself to the `LICENSE.txt` file after the long list of authors around the top.

Appveyor failure isn't you, if you remove the `[rfc]` when finished then cyco can poke it with his stick (may also need him to manually merge this one) Edit: It...

A value being `nil` itself in the config_finder.lua seems to cause breakages -- since it doesn't exist. And setting nil inside config.txt causes just as much breakage.

I think it's #2082 causing most of this bug on looking back. Hopefully fixing that also fixes this

@TheCycoONE #2106 has fixed this if it's enough for you to consider this done.

Gonna say it's Windows specific then. Just what @TheCycoONE wants to hear! 😄

It looks like it could be inside SDL. When music starts in the game audio.lua sends to SDL the configured music_volume. However, it looks like SDL is ignoring this in...

If this isn't easily fixable at the CPP end you could try pushing the volumes again on load a second time. It seems once the volume is sent to SDL...

Ah okay. It definitely looks like on load the volume isn't getting set. On my "fixed" install changing the volume in config to 0.9 did not increase the volume. I...

Some additional testing is showing that the sound (channel?) the music is being played to by SDL needs to actually be playing something to accept the volume change. Demonstrated by...