shadertutorialseries icon indicating copy to clipboard operation
shadertutorialseries copied to clipboard

snippets seem to be missing some functions you specifically mention being included

Open microncomputer opened this issue 5 years ago • 7 comments

I am watching the translate video and you just start typing circle and the circle function comes up, which you say is because it is in your snippets. I do not have it and after looking through your glsl.json file at https://gist.github.com/lewislepton for the word 'circle' I see nothing at all..

microncomputer avatar Nov 06 '19 18:11 microncomputer

great I was sure I didn't push something like that to the gist. remember there was some HD problems I had at the time.

anyhow. done ;)

lewislepton avatar Nov 07 '19 13:11 lewislepton

well, now it has the "circle shape" but this seems to be the only shape. There is no rectangle, which you also mention in episode 012

On Thu, Nov 7, 2019 at 5:58 AM Lewis Lepton [email protected] wrote:

Closed #1 https://github.com/lewislepton/shadertutorialseries/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lewislepton/shadertutorialseries/issues/1?email_source=notifications&email_token=AF6QDD24C6HHWIKUH6QFOIDQSQNGXA5CNFSM4JJZ3GBKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOUWVKSLQ#event-2779425070, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6QDDYRII74HLGD6QHN5DLQSQNGXANCNFSM4JJZ3GBA .

microncomputer avatar Nov 07 '19 18:11 microncomputer

my apologies. ill get that done. thanks again ;)

lewislepton avatar Nov 07 '19 19:11 lewislepton

boom. done. if there is any other things I've missed, please do let me know. ill keep this open for now then ;)

thanks for catching these. I just miss doing something when im sure ive done them. thank you so much for pointing these out ;)

lewislepton avatar Nov 07 '19 19:11 lewislepton

im just now looking thru the videos- to make sure im getting the other shapes.

this must have been the time I needed to do a fresh OS install & had HD trouble & lost what I had done with these small things.

but now... catching up & fixing ;)

lewislepton avatar Nov 07 '19 19:11 lewislepton

ok. ive gone thru all the files I have in the series & put in all the shapes & anything else that could be put into a snippet.

ill leave this open for the time being just in case a mystery code bit is missing ;)

thanks again ;)

lewislepton avatar Nov 07 '19 19:11 lewislepton

Thank you!

On Thu, Nov 7, 2019 at 11:36 AM Lewis Lepton [email protected] wrote:

ok. ive gone thru all the files I have in the series & put in all the shapes & anything else that could be put into a snippet.

ill leave this open for the time being just in case a mystery code bit is missing ;)

thanks again ;)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/lewislepton/shadertutorialseries/issues/1?email_source=notifications&email_token=AF6QDDZBTNUH3YURMM52PITQSRU2BA5CNFSM4JJZ3GBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDNR3TI#issuecomment-551230925, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6QDD5VRGT54VBW5SVAUT3QSRU2BANCNFSM4JJZ3GBA .

microncomputer avatar Nov 07 '19 22:11 microncomputer