abcm2ps icon indicating copy to clipboard operation
abcm2ps copied to clipboard

Work around for Qt's QSvgRenderer weakness.

Open be1 opened this issue 4 years ago • 4 comments

Hello, Qt's QSvgRenderer does not render correctly SVG files generated by abcm2ps. See: https://bugreports.qt.io/browse/QTBUG-88494 But maybe you would like to cherry-pick this workaround: 630a2355ce0dc915578b18e3960603e4d34cfbb8 from https://github.com/be1/qabc.git (in the lib branch)...

be1 avatar Nov 15 '20 13:11 be1

Hi, This does not work: you lose the 'currentColor'.

moinejf avatar Nov 15 '20 17:11 moinejf

Hello, Even if that patch is a bad hack (sure), currentColor isn't anyway "black" ?

be1 avatar Nov 15 '20 17:11 be1

No, it is not. Try that:

X:1
L:1/4
K:C
%%voicecolor red
CDEF|GABc|

moinejf avatar Nov 15 '20 17:11 moinejf

Thanks for the hint. If I could see in the code where currentColor is changed, I could modify the patch. But it seems currentColor is never changed, for now: colors change are written directly as color or bgcolor attributes, as I can see. e.g:

svg.c:		fprintf(fout, "color:#%06x;", gcur.rgb)

But I understand this could change in future versions, and that, anyway, currentColor is a handy feature that should not be broken (by my patch). So I won't cry ;-)

be1 avatar Nov 16 '20 07:11 be1