command-log-mode icon indicating copy to clipboard operation
command-log-mode copied to clipboard
verified publisher icon lewang

Make command log colorful

Open bmag opened this issue 10 years ago • 4 comments

Add two faces - one for keys and one for commands. You might want to adjust the faces' default values. They work fine with the theme I'm using, but not with the default emacs theme.

Implements #7

bmag avatar Dec 07 '15 19:12 bmag

+1 good job

stardiviner avatar Jan 15 '16 05:01 stardiviner

@lewang did you see this?

bmag avatar Feb 04 '16 09:02 bmag

@bmag Could you resolve the conflict so that your change can be checked into this git repo so that spacemacs can use this repo instead of your custom repo?

I took a shot and tried to resolve the conflict as shown below. The conflict is just in one line.

                 (insert (propertize (format "%s" (if (byte-code-function-p cmd) "<bytecode>" cmd))
                                     'face 'command-log-command))

emacs18 avatar Dec 14 '19 18:12 emacs18

@emacs18 your resolution looks correct to me. Is there anyone that will merge this PR if I resolve the conflict?

bmag avatar Dec 22 '19 18:12 bmag