Anselm Levskaya
Anselm Levskaya
Others sharp bits: - OOB accesses don't by default raise errors and silently clip or drop! This is already in there actually, but extend it a bit and mention the...
Also, making sure that the async set of JAX calls used in a training loop don't introduce blocking calls that will kill dispatch pipelining efficiency (e.g. trivial host-side metrics fn...
To make the below work: ``` class AutoEncoder(nn.Module): def init(self): self.encoder = Encoder() self.decoder = Decoder() ``` We'd have to write more logic to config these lazily once the module...
#2073 is a WIP first draft at removing the TF-dependence for basic IO operations. We can't shim something that will perform as well as the native gfile io calls, but...
My high-level view: ModuleLists are much less useful here than pytorch, since we really don't want to be mucking about with the submodules state after setup, compared to pytorch -...
@marcvanzee - curious though, what is the utility of an immutable ModuleList? I thought the main point of them in pytorch was capturing and processing all updates like append, etc?...
@andsteing - re (1) if we stick w. the current behavior, at a minimum we should certainly raise an Immutable error of some sort. For (2) there's a real question...
I'm honestly afraid that this cat is already out of the bag. Many users' models (and checkpoints!) now exploit the current freedom to set the name apart from python attribute...
To be safe I would want to rerun our examples to make sure this change doesn't break them... At least with transformer models I _think_ people settled on xavier-uniforms after...
Hmm, even with that uncommented I'm still getting infinite loops on other geometry. e.g. ```javascript martinez.intersection([[-36.24781525291243, 28.240373566184424],[-5.276960407892941, 69.94177839542625],[-10.689741059141994, 70.14384722952903],[10.59203885271558, 26.42123891266195],[9.619931709858415, 41.63423842491253],[-61.1981865514771, 44.346933376701756], [-36.24781525291243, 28.240373566184424]], [[-5.276960407892941, 69.94177839542625],[-36.24781525291243, 28.240373566184424],[-28.04892431686142, 27.43688541864268],[-5.276960407892941, 69.94177839542625]]) ```