node-modern-rcon icon indicating copy to clipboard operation
node-modern-rcon copied to clipboard

Type definition for node-modern-rcon.

Open electricessence opened this issue 6 years ago • 4 comments

Basic external type declaration that currently reflects rcon.js.

@levrik: thank you, and you're welcome. 😁

electricessence avatar Apr 22 '18 23:04 electricessence

Just a thought, I'm not sure if you need to be exporting the RconError since it's only instantiated internally.

I welcome you to review my main fork as well. There's some adjustments including logging and send can be immediately queued. Event handling is refined to be properly stateful. The state property is more informative.

But fundamentally, the code you wrote is solid. Thanks again. I'm able to connect to Factorio successfully using Nodejs. :) I wonder how easy this would be to port to the browser. :|

electricessence avatar Apr 22 '18 23:04 electricessence

It's exported so people can check via instanceof

levrik avatar Apr 23 '18 08:04 levrik

Oh yeah of course. Something I blanked on. :P

electricessence avatar Apr 23 '18 15:04 electricessence

@levrik Ok all set. I added the last touch to the project file so it includes the typings and updated the patch version so it can be published.

electricessence avatar Apr 25 '18 15:04 electricessence