Levin Rickert

Results 130 comments of Levin Rickert

I went ahead and created https://github.com/adobe/react-spectrum/pull/6591 as I needed this change anyway to unblock myself at work. Let me know what you think.

@devongovett Is there anything I can do to get a review on #6591? Maybe I missed something during the PR creation?

@devongovett That is an interesting idea. Let me try that in my codebase. Currently I'm using the patch from my PR and wrap components to fix the auto-completion but this...

@devongovett I gave it a try now but `params` are sadly not typed based on `to` but instead simply offer params from all routes. But I think that's what you...

@evadecker You should be able to pass the whole object passed to `useHref` into `buildLocation` instead of just `to`. I also tried this already but TBH I couldn't get `params`...

@evadecker Passing as string doesn't work if you define just `ToOptions` as it's the whole interface and not just the `to` string.

@mversic You have to type the full path in `to`. Only parameters that are already present in `from` are made optional in `params`. In your use-case there's no benefit of...

> But still, I wanted to do [this](https://tanstack.com/router/latest/docs/framework/react/guide/navigation#relative-links). That wouldn't work with RAC Yep as this requires properties to affect each other inside `ToOptions` which doesn't work within RAC. The...

> We suggest using something like [spectrum.adobe.com/page/contextual-help](https://spectrum.adobe.com/page/contextual-help/) (as mentioned here [react-spectrum.adobe.com/react-aria/Tooltip.html#accessibility](https://react-spectrum.adobe.com/react-aria/Tooltip.html#accessibility)) to help users understand that there is a disabled button and why it is disabled. What would you suggest...