akka-tracing
akka-tracing copied to clipboard
Use whitelists rather then blacklists for header and query annotations
Hi Lev, It is hard to know upfront all possible security related headers (e.g. containing authentication tokens/user info etc) which risks leaking sensitive info into Zipkin traces.
My previous implementation took a blacklisting approach. Based on the above security concerns, I now realise it is more sensible to have use a whitelist for inclusion of query params and header values then a blacklist.
Hi Lev, Good to see recent activity again on this repo. I have remerged from your updated master and resolved merge conflicts to make specific headers included. We have seen in our exploratory usage of akka-tracing that this feature is necessary as we have security credentials in headers (which vary across products) which must not be logged
Coverage increased (+0.3%) to 88.18% when pulling 4c6ff8e6985bcfdeded89633365baedcc3f63c4e on drpacman:master into fb4a6a18898b6e746764ba9ceaba7cd033cf5a55 on levkhomich:master.