rspec-snapshot icon indicating copy to clipboard operation
rspec-snapshot copied to clipboard

New Configuration Options, Use OJ for serialization / deserialization

Open rrcobb opened this issue 7 years ago • 5 comments

Pr is very messy right now, started it in an internal hackathon - mostly leaving here for comment / so I stop ignoring it. Before something like this merges, it should

  1. be split into multiple prs
  2. be cleaned of dumb editor changes (" to ' is my vim config, but is not actually a good change)
  3. be reviewed for design / features

Features added:

  • configure more about the way the snapshot is saved (configurable path, configurable extension)
  • read an env var to decide whether to save new snapshots or fail on a mismatch
  • load a snapshot from a name, (nominally, for use in other tests as a mock object, but I guess you could use it for other things too!)

rrcobb avatar Jan 19 '18 18:01 rrcobb

Hello @rrcobb , can you check the serializer branch? I've tried add a snapshot_serializer config and introduce awesome_print as a default serializer.

yesmeck avatar Jan 22 '18 14:01 yesmeck

Nice, I'll take a look at that branch and see whether I can just close this one. It could be there are small pieces of this that are worth pulling out, like making oj an optional serializer, taking a snapshot to a particular file, etc

rrcobb avatar Jan 25 '18 01:01 rrcobb

I like this PR, please continue your work.

timoschilling avatar Mar 02 '18 12:03 timoschilling

Some of this has been integrated into version 2.0.0. Up to you if you want to rebase and work out the conflicts for the remainder

levinmr avatar Jun 21 '21 19:06 levinmr

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Apr 19 '24 19:04 sonarqubecloud[bot]