Brian Leung

Results 43 comments of Brian Leung

The semantic highlighting makes it a bit easier for users to connect the dots when reading code. This is what we see without semantic highlighting (default Emacs theme + `rustic-mode`,...

> Is semantic highlighting conceptually different from what can be achieved with traditional Emacs font-lock and font-lock-keywords. It's be great to get rid of that complexity. But it successfully parses...

> Right. But are the font-lock keywords in rust-mode doing any work? Will you get the same colors if you simply remove those keywords? Or is it doing _some_ work?...

> And does it look exactly like the second example you posted here: [#615 (comment)](https://github.com/joaotavora/eglot/issues/615#issuecomment-773687842) ? > > Also, does this work with `rust-mode`? I redid with `rust-mode`, and with...

You could try https://github.com/raxod502/apheleia to cut down on unexpected `point` movement. It has some problems with undo history though. https://github.com/raxod502/apheleia/issues/15

> When I was trying the `source.fixAll` action I found that it only worked for the fixes on the current line (i.e. line cursor was on). If I selected a...

> Seems like we should change lsp--text-document-code-action-params which ATM > returns only the diagnostics on the current line/region. What we should most > likely do is to check if this...

@wandersoncferreira this patch resolves a breaking issue introduced in an upstream dependency; would you mind taking a look?

What's the status on this? It would be nice to see this merged in time for the upcoming 29.1 release in a few months. Is there anything we can do...