Hybrid Char editor - draw pens correctly

[AndyHOvine]

This is for the C64 in multi-colour character mode and also for the Vic 20. Not for C64 Hi-res char mode or C64 Bitmap mode.

Below I describe hi-res and multi-colour (hybrid) character modes, the issue is only with multi-color (hybrid) character mode.

Hi-res character mode

The image on the left is valid for C64 Hi-Res mode. 16 colours should be available. There should only be two pens - the background colour, and the drawing pen which allows one of the 16 inks to be used per 8x8 character cell. Therefore, this mode works correctly.

Multi-color character mode (Hybrid)

The image on the right is how C64 Multi-colour or Vic 20 character modes should look. At present it does not look or work this way.

1. There should be 4 pens, background, Aux, Border and character pens. (note I have raised a separate issue about the labels for Aux / Border being the wrong way around)
2. There should only be 8 colours for pen 3, the character pen, but repeated in two columns.
3. Pen 3's left column is for hi-res operations with that colour. It sets bit 3 of the C64/Vic's colour memory to 0.
4. Pen 3's right column is for mult-colour operations with that colour. It sets bit 3 of the C64/Vic's colour memory to 1.
5. The ink selected by the user in Pen 3 is not the same as inks used in pens 0, 1 or 2. See below.
6. Pen 3's left and right column need a label or visual cue to tell the user which colour is for hi-res operations and which is for multi-color operations - example 'hi' and 'mc' text in each ink box.

Additional issue

Item 5 - there is an undesired behaviour at present when selecting pens. Pens 0, 1, and 2 and Pen 3 can share colours, but they are different. For example, pens 0, 1 and 2 can be set to either 8 or 16 colours and pen 3 can be set to 8 colours + 8 colours with the multi-colour bit set.

In the screenshot, black, pink and red have been set for pens 0-2. If you click on these, an 'x' is placed in the box to show it is selected. An 'x' is also placed in the box for the corresponding box in pen 3. This is incorrect and causes a problem when using pen 3.

In multi-colour mode, pens 0-3 each produce a bit pattern on the drawing canvas - 00, 01, 10 and 11. Pen 3 should always draw with bit pattern 11 and it will do this most of the time, but due to the above issue, will not for all colours.

With Black, Pink and Red set for pens 0, 1 and 2, when selecting an ink from Pen 3, if multi-colour white is selected (TRSE shows this as Pink in the right column at present), the 'border' pen 1 pen is selected and bit pattern 10 is drawn on the canvas. It is not possible to select the white colour at all for MC drawing operations.

Similar, but different issues occur for pens 0 and 2, depending upon what ink they are set to,.

It is important to note that the 8 available inks in pen 3 are not and will never be the same inks used in pens 0, 1 and 2, even if they show the same colour

Hope that makes sense, please let me know on Slack if need further explanation about this problem.