website icon indicating copy to clipboard operation
website copied to clipboard

[WIP] Adds dark-mode support

Open tdelmas opened this issue 5 years ago • 5 comments

Uses prefers-color-scheme to display in dark mode when asked by the browser/OS (https://caniuse.com/#feat=prefers-color-scheme)

  • Graphs keeps a white background
  • Force a white background for sponsors logos
  • Remove the scrollbar when not needed for code

TODO:

  • [ ] move colors into vars
  • [ ] links are too dark
  • [ ] text is too bright
  • [ ] The blue of the Let's Encrypt logo (and in the "LINUX FOUNDATION COLLABORATIVE PROJECTS" header) is a little dark to show up against a black background
  • [ ] The brightness of the hero image feels a little jarring and out of place
  • [ ] Remove black lines between the sponsor logos
  • [ ] The "Donate" button at the bottom has black text
  • [ ] the black background the blue color of the "Donate" button feels over-saturated
  • [ ] text in the "Get Started" and "Sponsor" buttons inside the hero image is too light.

image

tdelmas avatar Nov 11 '19 13:11 tdelmas

Any argument for or against it? (related: https://community.letsencrypt.org/t/allow-users-to-select-dark-mode-theme/105987)

tdelmas avatar Nov 13 '19 14:11 tdelmas

This seems like a nice addition so long as it looks just as good as the non-dark mode. Thanks!

bdaehlie avatar Nov 13 '19 14:11 bdaehlie

I approve of adding dark mode in concept. I think this work-in-progress still needs a little work. Attached are a couple of screenshots from my Android device in dark mode.

Screenshot_20191113-110800 Screenshot_20191113-110805

Specific issues:

The blue of the Let's Encrypt logo (and in the "LINUX FOUNDATION COLLABORATIVE PROJECTS" header) is a little dark to show up against a black background. We should probably lighten that.

The brightness of the hero image feels a little jarring and out of place. Not sure how to fix this; probably it's best to just leave it alone.

The sponsor logos are on a white background. This is unavoidable because a lot of the sponsor logos would be unreadable on a black background. But it's awkward looking because there are black lines between the logos. I think we need to put all the logos in a big white box.

The "Donate" button at the botton has black text, while the rest of the text on the page has white text. Also, against the black background the blue color of the button feels over-saturated. Maybe match it to the blue used in hyperlinks?

jsha avatar Nov 13 '19 19:11 jsha

Also, I think the text in the "Get Started" and "Sponsor" buttons inside the hero image is too light.

jsha avatar Nov 13 '19 19:11 jsha

Bump

jimmywarting avatar Apr 27 '23 11:04 jimmywarting