website icon indicating copy to clipboard operation
website copied to clipboard

Manually break words for CJK translation of the title.

Open DDoSolitary opened this issue 6 years ago • 6 comments

This is a follow-up of the discussion on #585

Currently CJK versions of the title may be a bit ugly because the browser doesn't know the word boundaries. It would be better to break the sentence manually. See A7T#1 for details about how this can be achieved.

If this change is acceptable I will open a PR for it.

Ping @tdelmas @A7T

DDoSolitary avatar Aug 23 '19 14:08 DDoSolitary

Also, as currently there's no Japanese or Korean translation. Maybe we should also add a comment about this in i18n/en.toml to inform future translators of these languages.

DDoSolitary avatar Aug 23 '19 14:08 DDoSolitary

已有日语翻译待合并: https://github.com/letsencrypt/website/pull/621

A7T avatar Aug 23 '19 14:08 A7T

@A7T 那个问题不大,涉及这里修改的i18n/ja.toml还没有翻译过

DDoSolitary avatar Aug 23 '19 14:08 DDoSolitary

要不要 Ping 一下日语翻译贡献者?

A7T avatar Aug 23 '19 14:08 A7T

先看 @tdelmas 是否接受这边的提案把

DDoSolitary avatar Aug 23 '19 14:08 DDoSolitary

Thanks for notifying the problem of the title. 😄

Currently CJK versions of the title may be a bit ugly because the browser doesn't know the word boundaries. It would be better to break the sentence manually.

As @DDoSolitary says It's true in Japanese sentence too. When translating, I've considered inserting <br /> to make the title more beautiful but I also notice that it makes the title broke in an unwanted manner when viewing in the mobile device (using Chrome DevTool). So I didn't do a manual breaking now. Is there a good idea?

In my opinion, in the case of the Japanese page, it is not perfect but acceptable.

shuuji3 avatar Aug 23 '19 15:08 shuuji3