website icon indicating copy to clipboard operation
website copied to clipboard

Add sinhala (si) language (Fix #1295)

Open tdelmas opened this issue 3 years ago • 6 comments

Add sinhala (si) language (Fix #1295)

tdelmas avatar Nov 07 '21 10:11 tdelmas

Small modification: https://github.com/tdelmas/website/pull/62 We would like to see this language on the official website; should we translate more than now? (sinhala - 15%) However we'll try to complete the rest soon. E.g. indonesian - 13%, serbian - 13% etc (already available)

sayuri-gi avatar Jul 13 '22 14:07 sayuri-gi

@sayuri-gi hello! Right now I believe most of the main documents have been translated and are ready to be put on the website. @tdelmas should be able to pull things over -- although Tom I can also do this if you'd like, though I'm not sure I know how to add things to someone else's PR 😅. Such is life when you're not a technical person.

ashmoremsp avatar Jul 13 '22 18:07 ashmoremsp

@ashmoremsp I should be able to do it this week 🙂

tdelmas avatar Jul 14 '22 10:07 tdelmas

@ashmoremsp I let you check if everything is OK, and merge it 🙂

tdelmas avatar Jul 14 '22 10:07 tdelmas

@tdelmas can you apply mentioned changes? https://github.com/tdelmas/website/pull/62/files e.g. you can add manually too.

sayuri-gi avatar Jul 14 '22 13:07 sayuri-gi

Looks good for me! @scottmakestech can you approve this?

ashmoremsp avatar Jul 15 '22 14:07 ashmoremsp

Nov 7, 2021 - Aug 27 2022 | 9 months When will you merge this? You can check for site code issues and just merge!

neotrak avatar Aug 26 '22 22:08 neotrak

@tdelmas or @scottmakestech -- apologies for tagging you after hours!

ashmoremsp avatar Aug 26 '22 22:08 ashmoremsp

Approving this based on prior approvals from @tdelmas and @ashmoremsp.

scottmakestech avatar Aug 26 '22 22:08 scottmakestech

Unfortunately the build failed only after merge, and I had to revert. (#1448)

@tdelmas Are you able to take a look? Unfortunately I don't have much availability at the moment.

scottmakestech avatar Aug 26 '22 22:08 scottmakestech

Adding link to failed build: https://github.com/letsencrypt/website/actions/runs/2936929555

scottmakestech avatar Aug 26 '22 22:08 scottmakestech

@scottmakestech I've open https://github.com/letsencrypt/website/pull/1449 to investigate, I'll update you there as soon as possible.

tdelmas avatar Aug 27 '22 09:08 tdelmas