pebble icon indicating copy to clipboard operation
pebble copied to clipboard

Orders don't have a "deactivated" status.

Open jsha opened this issue 4 years ago • 4 comments

Use "invalid" instead, and add comments linking to the spec.

Fixes #300

jsha avatar Feb 24 '20 23:02 jsha

:wave: FWIW Boulder has the same divergence: https://github.com/letsencrypt/boulder/blob/9a86abc1550425a73f912c25a11c29160f58a85a/sa/sa.go#L1218-L1221

cpu avatar Feb 25 '20 14:02 cpu

I think I managed to still trigger this. I need to do a few more tests to make sure i'm running the right code - I'm not very good with go

jvanasco avatar Feb 27 '20 00:02 jvanasco

Ok, thanks so much for testing! If you need any help, let me know.

jsha avatar Feb 27 '20 00:02 jsha

I finally got a chance to test. This works as expected from the RFC.

jvanasco avatar Jun 12 '20 20:06 jvanasco