boulder icon indicating copy to clipboard operation
boulder copied to clipboard

sa: use model struct for Certificate, CertificateStatus, FQDNSet

Open jsha opened this issue 11 months ago • 1 comments

In the SA, we mostly use structs internal to the SA to represent the database's storage of various objects, and translate those objects into proto messages to return from RPCs. There are three exceptions:

https://github.com/letsencrypt/boulder/blob/bc3978090881ff3fc816692cdbd380e89b563d66/sa/database.go#L272-L274

Certificate, CertificateStatus, and FQDNSet use types from the core package as models. We should switch these to SA-internal models.

jsha avatar Apr 09 '25 17:04 jsha

The last bit of this, FQDNSet, requires some more tweaks to the expiration-mailer unittest. Rather than make those tweaks I'm going to consider this blocked on the removal of expiration-mailer.

jsha avatar May 13 '25 17:05 jsha

This bug is now unblocked!

aarongable avatar Jun 17 '25 21:06 aarongable