Add sqlclosecheck to golangci-lint configuration

[mcpherrinm]

This linter helps identify failure to close sql rows, which can lead to connection pool issues.

This PR is a "WIP" because there's some failures, but they don't look immediately important.

[joakime]

You sure it's 12.0.1?

This seems a lot like Issue #10120 reported against 12.0.0 betas, and fixed with the final 12.0.0 release.

[jaroslawr]

Yes I am sure, we never used the beta releases.

[lorban]

@jaroslawr Sorry for the delay getting back to you.

Have you got any news about this issue? I checked the GZIPContentDecoder failure path, and there is no obvious way suppressed exceptions could accumulate over time. The RuntimeException thrown when a decoding error occurs is forwarded via fail() to the Content.Source from which the bytes were read, which eventually should be the HttpChannelState, the latter eventually clearing its exception in recycle() once the request has been fully processed.

You VisualVM screenshot does not show which object references that exception with thousands of suppressed exceptions, so which one was it? Is it changing over time?

Any more information you can collect would help track down the problem.

[github-actions[bot]]

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

[joakime]

No longer valid, likely fixed in other issues.