boulder icon indicating copy to clipboard operation
boulder copied to clipboard
verified publisher icon letsencrypt

grpc: Replace deprecated otelgrpc interceptors

Open pgporada opened this issue 2 years ago • 4 comments

This should stay in draft mode until this upstream bug is fixed.

Fixes https://github.com/letsencrypt/boulder/issues/7235

pgporada avatar Jan 03 '24 03:01 pgporada

I think filtering healthchecks isn't actually that important, so it would be fine to merge this and have a tracking bug to filter them later. We can always drop them in the collector, if we need.

mcpherrinm avatar Jan 25 '24 01:01 mcpherrinm

There's an open PR to add filtering, I'm inclined to let that play out and wait for a new otelgrpc version to be released.

pgporada avatar Apr 04 '24 15:04 pgporada

The upstream PR has been merged, but we need to wait for a new otelhttp release to be cut. The existing version bump https://github.com/letsencrypt/boulder/pull/7467 has problems, so :|.

pgporada avatar May 10 '24 19:05 pgporada

#7467 has been merged, is this now ready to move forward again?

Answer: No, the release we updated to doesn't contain the relevant PR. We still need to wait for the next release.

aarongable avatar May 20 '24 19:05 aarongable

Replaced by https://github.com/letsencrypt/boulder/pull/7496

aarongable avatar May 29 '24 22:05 aarongable