rawpy icon indicating copy to clipboard operation
rawpy copied to clipboard

Generalize Linux and macOS CI build scripts to also work locally in a robust way

Open harshithdwivedi opened this issue 4 years ago • 2 comments

The current scripts are supposed to work in a CI environment. On trying these on a local machine; if the build fails due to some reason, subsequent attempts to build rawpy won't work and you might see errors like:

+ source .github/scripts/retry.sh
+ export MACOSX_DEPLOYMENT_TARGET=10.9
+ MACOSX_DEPLOYMENT_TARGET=10.9
+ export PYTHON_INSTALLER_MACOS_VERSION=10.9
+ PYTHON_INSTALLER_MACOS_VERSION=10.9
+ '[' 3.7 == 3.5 ']'
+ git clone https://github.com/matthew-brett/multibuild.git
fatal: destination path 'multibuild' already exists and is not an empty directory.

We need to have new scripts that take this case into account and add some documentation to the Readme on how to use them as well.

harshithdwivedi avatar Apr 10 '20 15:04 harshithdwivedi

Instead of having new mostly copied scripts I would rather try to make the CI scripts more generic so that they also work locally well.

letmaik avatar Apr 10 '20 15:04 letmaik

Sure thing, doing that makes more sense.

On Fri, 10 Apr 2020, 21:28 Maik Riechert, [email protected] wrote:

Instead of having new mostly copied scripts I would rather try to make the CI scripts more generic so that they also work locally well.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/letmaik/rawpy/issues/108#issuecomment-612094546, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALLWCVEZM23C62LVOEQJD4TRL462ZANCNFSM4MFQK5XA .

harshithdwivedi avatar Apr 10 '20 16:04 harshithdwivedi