Titouan Rigoudy
Titouan Rigoudy
@jonathanmetzman PTAL, this is a prereq for https://github.com/google/clusterfuzz/pull/3934 which aims to fix an issue where regression task can get stuck.
Thanks for the review! Addressed your comments.
> Is there a purpose to setting these if the cron job clobbers the user set weights? I don't think the cron job does. IIUC it clobbers the multipliers. See...
If I read the code correctly, the cron job only mutates `FuzzerJob.multiplier` values, not `FuzzerJob.weight` values. Can we simply manually set `FuzzerJob.weight` instead?
Ah, I misread the issue. This is about engine fuzzers. There is indeed no way to manually set weights for libfuzzer and afl fuzz targets, since the weights are clobbered...
It seems to me the most straightforward solution here would be to introduce the weight/multiplier distinction for fuzz targets as is done for fuzzers, and have the cron job adjusts...
I want to test it out locally to see if it works on my machine (tm), then I guess we can try merging!
I can confirm that `local/install_deps.bash` works with the updated pipenv. I'll see about updating the version used on Mac too.
On Mac `local/Brewfile` is used to install pipenv using homebrew, with no version specification. I think this is good to merge!