RigelEngine icon indicating copy to clipboard operation
RigelEngine copied to clipboard

Published 20 hours ago • verified publisher icon lethal-guitar

Mod directories with non-ASCII names aren't displayed correctly

Open lethal-guitar opened this issue 2 years ago • 4 comments

lethal-guitar avatar Nov 20 '22 12:11 lethal-guitar

Hello @lethal-guitar :wave:

How are you doing. Would like to give this a shot. How do we reproduce this this and also never thought of non-ASCII names for files and directories until seeing this.

naftalimurgor avatar Dec 09 '23 14:12 naftalimurgor

Hi @naftalimurgor, doing alright, thanks! Happy to hear you're interested in tackling this 🙂

To reproduce:

  • Download one of the mods from the list
  • Place it into <Game data dir>/mods/<name of mod>
  • Rename the directory to contain some non-ASCII characters, e.g. Täßtîng 東京
  • Now, when you launch the game and open the mod manager in the options menu, the non-ASCII characters will be displayed as ???? in the UI.

This happens due to the built-in font coming with the Dear ImGui library not having Unicode glyphs. There should be a fair bit of information on how to add Unicode support on the Dear ImGui wiki.

lethal-guitar avatar Dec 09 '23 18:12 lethal-guitar

Hey @lethal-guitar Glad to hear you are doing well! Taking on this. and will submit a PR as soon as things are set up!

naftalimurgor avatar Dec 09 '23 21:12 naftalimurgor

Hello @lethal-guitar :wave:

I hope you are doing great, been quite busy with college and school work.

Regarding this issue, I found out an issue describing similar edge case faced here: https://github.com/ocornut/imgui/issues/565 Hopefully the pointers highlighted in this issue will help resolve this issue

naftalimurgor avatar Jun 20 '24 08:06 naftalimurgor