lestrrat
lestrrat
First of all, thanks for taking the time to review this in such depth. I'm pretty impressed you took the time to dig deep into this codebase's guts :) So...
tl;dr: * Since you say you can't do it in v2 without breaking API compatibility, there's no possibility of me taking this PR. As such I won't comment further on...
Looks *almost* good to me ! One thing I think you can do is to actually remove this restriction: > https://github.com/lestrrat-go/jwx/pull/1143/files#diff-c2439f931b7a6e1c34aa6296f4785add4154071eeb4bf050b363045f51dd359fR138 ```go // RegisterKeyEncryptionAlgorithm registers a new KeyEncryptionAlgorithm so that...
> I think that because invalid options can be provided (not all algorithms can accept the WithSymmetricAlgorithmoption), an error has to be returned I think you can get away by...
@Hannes-Kunnen Sorry, I was away for vacation, and am now trying to catch up with life in general. I should come back to this soon enough, but just not yet....
@Hannes-Kunnen I added some minor tweaks to your branch in https://github.com/lestrrat-go/jwx/tree/Hannes-Kunnen-v2-genjwa-is-symmetric-asymmetric. If you're okay, I'll merge your changes from my branch. > I've implemented this change, but am wondering how...
@Hannes-Kunnen I thought you retracted those. Do you want to continue on this thread? That just means this PR isn't going to be merged until this is all resolved. ---...
As I said, I'm in agreement that it's probably OK, but I'm saying it does not sound like something that I feel compelled to include right at this moment, because...
@Hannes-Kunnen TBH never had to deal with minor releases yet, so I suppose I'm going to have to split out a branch for develop/v2.2 :)
@Hannes-Kunnen FYI https://github.com/lestrrat-go/jwx/tree/develop/v2.2. I have no concrete plans for this branch, but throwing it out there so you have something to work with