ejml icon indicating copy to clipboard operation
ejml copied to clipboard

ejml-ddense 0.34 references J2SE classes

Open kjkrum opened this issue 6 years ago • 2 comments

ejml-ddense and ejml-fdense version 0.34 reference java.awt and javax.swing packages, making them unusable (or at least requiring a workaround) in Android projects. It seems like a mixing of concerns for EJML to reference UI classes. Can this usage be avoided or split into another module?

kjkrum avatar Jul 10 '18 18:07 kjkrum

It probably should be split off into a different package, however it shouldn't be causing problems in Android either. Are you trying to build EJML or just include the modules? I got a similar bug report years ago and the person was trying to build EJML in an Android project.

lessthanoptimal avatar Jul 11 '18 04:07 lessthanoptimal

I'm just including EJML as a dependency. The heavy handed solution is to disable lint. This isn't a big problem for me, more of a suggestion for improving the library.

kjkrum avatar Jul 13 '18 05:07 kjkrum

While swing code should be moved to a separate module, this hasn't been causing any problems in the past few years so I'm going to close the ticket. If someone was to add a main/ejml-swing package and move all this code there it will be accepted.

lessthanoptimal avatar Jan 14 '23 00:01 lessthanoptimal