Leslie Cohn-Wein

icon indicating a website link leslie.dev icon indicating an email [email protected]

icon company @github icon location Dallas, TX icon location Frontend people person into React, CSS, a11y, wine, & design. Staff Engineering Manager @github. Ex @netlify @canvasnyc IBM iX. Pronounced CONE🍦-Wine🍷.

Results 232 comments of Leslie Cohn-Wein

Document the need to `include Primer::ViewHelper` in order to use the helpers

👋🏻 Hi @kjg, thanks for reporting this! We would welcome a PR to the docs; I believe [this is the file](https://github.com/primer/view_components/blob/main/docs/content/index.md) to edit. Let us know if we can help!

ActionList.Group should allow for TrailingActions

Thanks for filing! We're going to explore the accessibility implications of this and will get back to you.

Unable to cycle focus using tab/shift+tab inside of AnchoredOverlay

Hi @marywhite, so sorry we didn't get back to you on this! Can you confirm that this is still a challenge and, if so, we'll triage this issue further?

Button content grid cells are equal

Hey @dusave, I'm so sorry we didn't get back to you on this much sooner! Apologies 🙏🏻 Are you able to confirm this is still a problem?

Button content grid cells are equal

Noting that the linked PR includes breaking changes, so we'd schedule them to go out with the next major release. @joshblack noted there may be some changes we could pull...

setColorMode not working within useEffect

@colebemis since you're on FR this week and familiar with this issue, could you take a peek and re-open if this issue is still valid? Thank you!

Tooltips not taking into account the margin of their anchor

👋🏻 @jdrush89 is this still a problem you're seeing?

ADR 009: Guidelines for interaction tests in primer-react

Thanks for contributing this ADR, @pksjce! In order to help move a decision forward, I'm assigning the following: **ADR decision maker:** @colebemis **Decision deadline:** EOD Monday, 22 August Your role...

useColorSchemeVar should provide explicit color assistance/types and/or primer reexports primitives

Thanks for discussion here! I'm going to move this to our unprioritized backlog so we can consider type safety for primitives in our next round of Primer planning. To be...

Tooltip should be in a Portal

Thanks @dgreif, we agree with this assertion. Moving to the backlog to address in the future.