Aurélien

Results 46 comments of Aurélien

Thanks for opening this issue! Yes, I would appreciate a minimal repro.

@mattsse the test `test_sending_invalid_transactions` is failling because it's creating an invalid signature, but now with the conversion to alloy `Signature` we create a `k256::ecdsa::Signature` and it fails. Should as_alloy_signature() returns...

@mattsse Unfortunately alloy-primitives "k256" feature is enabled due to this in alloy-signer: https://github.com/alloy-rs/alloy/blob/423a4c53c1bffdfb2acca2daee60215194f7711d/crates/signer/Cargo.toml#L22C7-L22C18 And also this in revm-primitives: https://github.com/leruaa/revm/blob/1adc908dfa924a9cd5673b526ecbaaec7298d60f/crates/primitives/Cargo.toml#L25

To add a bit of context: The issue with the test [test_sending_invalid_transactions](https://github.com/paradigmxyz/reth/blob/4a1916155752db84679315aa56175bf3f331adac/crates/net/network/tests/it/txgossip.rs#L102) is that it create an invalid signature here: https://github.com/paradigmxyz/reth/blob/4a1916155752db84679315aa56175bf3f331adac/crates/net/network/tests/it/txgossip.rs#L132 Deeper in the code this signature is converted to...

Unfortunately we can't use a type alias because `Signature` is private.

@mattsse Unfortunately there is an unexpected complication, initially a test was in error because the chain_id was lost during a `TransactionSigned ` encode/decode, ~~so I changed `odd_y_parity` bool to `parity`...

I realize this is not taken into account anymore: https://github.com/paradigmxyz/reth/blob/ae8ce20c0b433f401f596fb7860b4e66a8657a61/crates/primitives/src/transaction/signature.rs#L93-L100 Let me add a commit

@smartiov @deerzhang @Atamanov Is the moongate server version you are running is `v4.2.1`? What is the output of: ``` docker image ls | grep moongate ```