lerna-changelog icon indicating copy to clipboard operation
lerna-changelog copied to clipboard

Published 20 hours ago • verified publisher icon lerna

Dedupe issues with multiple labels

Open gigabo opened this issue 8 years ago • 5 comments

Currently if an issue has multiple labels that are in the changelog configuration it will get listed in each section. Should only list in one. See entries about <TheFold /> here.

gigabo avatar May 27 '16 16:05 gigabo

@gigabo should we change the labels object to an array and use the order as priority? or define a priority explicitly?

Turbo87 avatar Mar 03 '17 21:03 Turbo87

I think key traversal is actually in definition order for objects from JSON in modern node. Might not need to change the format.

gigabo avatar Mar 03 '17 22:03 gigabo

was just wondering if order in changelog should always equal priority. e.g. if you want the labels alphabetically but with other prio for deduping?

Turbo87 avatar Mar 03 '17 22:03 Turbo87

Oh, could be.

They're the same for us with React Server since we try to front-load things that people are most interested in.

gigabo avatar Mar 03 '17 22:03 gigabo

I think key traversal is actually in definition order for objects from JSON in modern node.

https://stackoverflow.com/a/5525812/1478093

apparently it works, but it's not guaranteed. I'd prefer to be explicit about the order... 🤔

Turbo87 avatar May 29 '17 10:05 Turbo87