lerna-changelog icon indicating copy to clipboard operation
lerna-changelog copied to clipboard

Fetch error: not found

Open slorber opened this issue 3 years ago • 4 comments

I'm trying to release a new Docusaurus version and got a weird error when generating the changelog.

In the downloadIssueData I added a try/catch and noticed it tries to fetch an issue that does not seem to exist 🤪

image

image

And nothing can be found at https://github.com/facebook/docusaurus/issues/4018

I don't know if it's Github API that should not return 4018 in the first place, or a bug in Lerna, just wanted to report this issue.

However I think it could be useful to add an option to fail-safe in case of such fetch errors, or at least print the issue number in the error message so that user does not have to hack inside the library code to find the reason this fails?

slorber avatar Mar 09 '21 16:03 slorber

I don't know if it's Github API that should not return 4018 in the first place, or a bug in Lerna, just wanted to report this issue.

we are essentially parsing the commit messages for common merge commit patterns and extracting the issue numbers from that. it could be that this is a false positive, but I agree that it shouldn't error just because of that 😅

Turbo87 avatar Mar 10 '21 09:03 Turbo87

I think having an error printed to the console wouldn't be a big deal.

However when you are in the middle of a release and you are stuck because you can't generate the changelog, it can be more annoying 😅 just adding a try/catch would be a quick win

slorber avatar Mar 10 '21 10:03 slorber

@Turbo87 also hitting this in a private repo, it's a bit unclear why. I've set the github token and all PRs are labelled. Anything we can do to make this more debuggable?

runspired avatar Mar 05 '22 02:03 runspired

a PR with a bunch of debug prints maybe 😅

Turbo87 avatar Mar 05 '22 07:03 Turbo87