lerna-changelog
lerna-changelog copied to clipboard
Renovate bot is not ignored despite using default config
Hi there, I see that (via #105) lerna-changelog is supposed to exclude PRs by bots like Renovate by default:
https://github.com/lerna/lerna-changelog/blob/331539b40c02f68f9c75c4f7db017977e1e62d28/src/configuration.ts#L61-L70
However, this doesn't seem to be working for my repo, and I can't figure out a manual config to get it to work either. Are there limitations to how it works, or did something maybe break in the time since that PR was merged a few years back?
Poking around a bit, it looks like ignoreCommitters
is only referenced here:
https://github.com/lerna/lerna-changelog/blob/01013b0bfe1ac4abd41c693a2714aaa2afebf2b5/src/changelog.ts#L118-L120
This in turn is only referenced by getCommitters
, which is only used for filling out contributor info at the bottom of a release, not for actually filtering commits. And indeed, bots are correctly ignored in the list of contributors, even if their commits are included in the changelog. For example, I'm seeing output like this:
Bug Fix
- #5015 fix(deps): update dependency xyz to ^2.10.1 (@renovate[bot])
Committers: 0