lerna-changelog icon indicating copy to clipboard operation
lerna-changelog copied to clipboard

Retrieve PR's for commits from new GitHub API

Open rwjblue opened this issue 4 years ago • 2 comments

GitHub introduced a new API for determining which PR a commit came from, we could use this API to avoid the multiple regular expression matchers that we are having to use today (e.g. the "squash and merge" style, the "merge commit" style, "homu", etc).

References:

rwjblue avatar Oct 22 '19 20:10 rwjblue

This seems very useful, to make the detection stable.

I just played around with my IDE's (JetBrains) ability to interact with the Github APIs, in this case reviewing and merging a PR. Apparently it caused the merge commit to have a different message than usual:

image

The from part is missing from this regex, so didn't get any changelog information...

simonihmig avatar Apr 20 '21 14:04 simonihmig

Could it allow to use lerna-changelog with PRs rebased and not only merged or squashed?

thibaultdalban avatar May 04 '21 08:05 thibaultdalban