shibuya icon indicating copy to clipboard operation
shibuya copied to clipboard

Theme reverts to default when page is reopened

Open Alc-Alc opened this issue 9 months ago • 1 comments

Not sure if it's a feature request or issue or a config issue

Steps

  1. Visit https://shibuya.lepture.com/
  2. Change the theme to something that is not default (eg: if you are on light mode, change to dark mode and vice-versa)
  3. Close the page
  4. Reopen the page and notice that the theme is reverted (not the one you selected)

Thanks

Alc-Alc avatar May 13 '24 04:05 Alc-Alc

Not sure if this is a conscious decision you made but I think the following should be stored in localStorage not sessionStorage?

https://github.com/lepture/shibuya/blob/c4e869220964de5bef857d26fd41d39783d6d066/static/js/theme.js#L12

Alc-Alc avatar May 13 '24 07:05 Alc-Alc

Fixed in master code.

lepture avatar May 19 '24 13:05 lepture