github-cards icon indicating copy to clipboard operation
github-cards copied to clipboard

Not rendering in Safari

Open bretonics opened this issue 7 years ago • 6 comments

For some reason it has stopped rendering in Safari browser. In all other browsers, it does show up but the background for the themed github card is black.

bretonics avatar Jul 06 '17 04:07 bretonics

jsdelivr has a bug now. try lab.lepture.com

lepture avatar Jul 06 '17 07:07 lepture

I replaced cdn.jsdelivr.net/github-cards/latest/widget.js with lab.lepture.com/github-cards/widget.js to get it working again.

etoews avatar Jul 09 '17 22:07 etoews

Hey @bretonics @lepture @everett-toews, I've just replaced the URL like proposed above ! The script is now loading again, but the background is black (as pointed out on the first message issue, I suppose) 🙁

Thanks for this project anyway 👋

EDIT: This asset is not loading correctly : https://assets-cdn.github.com/assets/modules/aws/aws-bg-80b292690ba587b305c2c038c496ffc8ff08d3bf6be6c1ba64d48bedc09cc36f.jpg

HorlogeSkynet avatar Jul 11 '17 07:07 HorlogeSkynet

@HorlogeSkynet, indeed. I suppose that should be a simple switch for the source here and here then...?

@lepture, Why not have the background image in this same repo?

bretonics avatar Jul 12 '17 14:07 bretonics

@bretonics PR is welcome

lepture avatar Jul 13 '17 00:07 lepture

I've done some tests using the new jsDelivr method being implemented and it seems that because of the switch from //cdn.jsdelivr.net/github-cards/latest/widget.js to what going forward should be //cdn.jsdelivr.net/gh/lepture/github-cards@latest/jsdelivr/widget.js causes the issue.

Since the new method auto-updates, and the old has stopped doing so ref, it seems to me the problem lies in that it tries to find version the latest version, 1.0.3, in the CDN files stored, but is unable since this file is missing from jsDelivr.

If you try //cdn.jsdelivr.net/github-cards/1.0.2/widget.js or the new method //cdn.jsdelivr.net/gh/lepture/github-cards@latest/jsdelivr/widget.js, you get an HTML doc, yet implementing //cdn.jsdelivr.net/gh/lepture/github-cards@latest/jsdelivr/widget.js results in "Couldn't find the requested release version 1.0.3."

bretonics avatar Jul 14 '17 14:07 bretonics