authlib icon indicating copy to clipboard operation
authlib copied to clipboard

Incorrect check for insecure transport on OAuth1.0

Open Zaczero opened this issue 1 year ago • 0 comments

Describe the bug

The current implementation of OAuth1Request checks for insecure transport which is incorrect. OAuth 1 is protocol-independent and it does not depend on TLS layer to secure the communication. This check is only necessary during OAuth 2 communication.

Additionally, the error description mentions OAuth 2 which indicates that this class was accidentally copied over from OAuth 2 implementation.

Expected behavior

OAuth1Request does not check for insecure transport and the InsecureTransportError is removed.

Zaczero avatar Feb 17 '24 08:02 Zaczero