tornado-redis icon indicating copy to clipboard operation
tornado-redis copied to clipboard

remove called unsubscribe callbacks from list of callbacks

Open sjhewitt opened this issue 9 years ago • 4 comments

When unsubscribing from pubsub channels, a reference to expired callbacks was kept.

This change updates the unsubscribe_callbacks list to remove references once a callback has been called

sjhewitt avatar Jul 28 '15 17:07 sjhewitt

Any update on this? I'm seeing leaking clients when unsubscribing.

AeroNotix avatar Jan 12 '16 09:01 AeroNotix

@sjhewitt If you push/amend the commit, travis will try again, looks like the failures weren't related to your changes.

AeroNotix avatar Jan 12 '16 09:01 AeroNotix

Tested this locally, does not fix a client leak when unsubscribing. The websocket example leaks clients. @sjhewitt @leporo any ideas?

AeroNotix avatar Jan 12 '16 09:01 AeroNotix

Can you create a failing test case or bit of example code?

sjhewitt avatar Jan 26 '16 16:01 sjhewitt