wpfui icon indicating copy to clipboard operation
wpfui copied to clipboard

Don't focus on inline buttons or icons in text input controls when pressing Tab

Open tmijail opened this issue 1 year ago • 0 comments

Avoid tab-focusing on ControlIconLeft, ControlIconRight, ClearButton, InlineIncrementButton, InlineDecrementButton, and/or RevealButton present in TextBox, AutoSuggestBox, NumberBox and PasswordBox by setting IsTabStop=False

Pull request type

Please check the type of change your PR introduces:

  • [ ] Update
  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes

What is the current behavior?

When you press Tab on a text input control which has inline buttons (ClearButton, InlineIncrementButton, InlineDecrementButton, RevealButton), it focuses on those buttons instead of on the next control.

This breaks the flow and is inconsistent with WinUI3.

https://github.com/lepoco/wpfui/assets/6920322/0fc342da-b5c1-47a0-ab29-3349263ad638

Issue Number: N/A

What is the new behavior?

Don't focus on buttons in text input controls with Tab.

https://github.com/lepoco/wpfui/assets/6920322/b3b4cb45-497b-4dbd-a03d-72a02f75839f

Other information

tmijail avatar Feb 26 '24 19:02 tmijail