wpfui icon indicating copy to clipboard operation
wpfui copied to clipboard

Published 20 hours ago • verified publisher icon lepoco

Update TextBox control

Open Wimpin opened this issue 2 years ago • 1 comments

Don't show ClearButton when textbox is read only.

Pull request type

Please check the type of change your PR introduces:

  • [x] Update
  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] Documentation content changes

What is the current behavior?

When using the TextBox control in ReadOnly mode it will show the ClearButton.

Issue Number: N/A

What is the new behavior?

Now When you use the TextBox control in ReadOnly mode it will no longer show the ClearButton

Other information

Wimpin avatar Aug 28 '22 19:08 Wimpin

Hey @Wimpin, thank you for your contribution to the project. Could you also have a look at other controls that are related to text editing and might need this change?

https://github.com/lepoco/wpfui/blob/b7c0b06aa1042c2c6a677c38e56d24cd9c3897bf/src/Wpf.Ui/Controls/AutoSuggestBox.cs#L25 https://github.com/lepoco/wpfui/blob/b7c0b06aa1042c2c6a677c38e56d24cd9c3897bf/src/Wpf.Ui/Controls/NumberBox.cs#L26

pomianowski avatar Aug 30 '22 18:08 pomianowski