wpfui icon indicating copy to clipboard operation
wpfui copied to clipboard

Published 20 hours ago • verified publisher icon lepoco

Light Mode: TabItem selected

Open jasmeet21 opened this issue 2 years ago • 4 comments

Describe the bug
Light mode missing indication of which TabItem is selected

Expected behavior
On TabItem selection it should present darker color to represent which tab is selected

Screenshots
Light Mode: image

Dark Mode: image

Desktop (please complete the following information):

  • OS: [e.g. Windows 10]
  • .NET: [ net6.0 ]
  • Version: v1.x & v2.0.1

jasmeet21 avatar Jun 20 '22 04:06 jasmeet21

Nope, the colors match the winui 3 style. But I would suggest removing the extra border at the bottom of the tabs.

image_2022-06-20_105655651

MajorXAML avatar Jun 20 '22 07:06 MajorXAML

I have not closely look into winui 3 colors but i think your suggestion would be far better instead of changing color as i suggested. Thanks MajorXAML

jasmeet21 avatar Jun 20 '22 09:06 jasmeet21

Used a color picker to compare the two light examples.

The WPF UI screenshot: Selected tab color = FEFEFE (254) Not selected tab color = FBFBFB (251) Only 3 steps difference in the greyscale (I can hardly tell a difference on my monitor).

The WIN UI screenshot: Selected tab color = F9F9F9 (249) Not selected tab color = F3F3F3 (243) 6 steps difference in the greyscale.

The difference between selected and not selected tab is twice as big in the WIN UI and much easier to see (also thanks to the missing line as you say).

ekdahl avatar Jun 20 '22 17:06 ekdahl

@ekdahl The color picker will not work as it should because most colors in winui have varying degrees of transparency and their color depends on the background color.

In the case of TabView, the colors will be as follows: SolidBackgroundFillColorTertiaryBrush CardStrokeColorDefaultBrush

MajorXAML avatar Jun 24 '22 15:06 MajorXAML