mulrel-nel icon indicating copy to clipboard operation
mulrel-nel copied to clipboard

dim inconsistent in use local only mode

Open hitercs opened this issue 6 years ago • 2 comments

Hi, Thanks for your work. https://github.com/lephong/mulrel-nel/blob/db14942450f72c87a4d46349860e96ef2edf353d/nel/mulrel_ranker.py#L153

I found that when config[use_local_only] = True, the code results in dimension inconsistent errors. That is caused by concating a zeros tensor with two scores. Is this a bug? Could you please fix it?

Thanks.

hitercs avatar Dec 01 '18 03:12 hitercs

Thanks for letting me know. Let me fix it. In the mean time, if you are interested in only local local mode, you might want to have a look at https://github.com/dalab/deep-ed. Their local and our local models are identical.

lephong avatar Dec 01 '18 11:12 lephong

Great, thanks.

hitercs avatar Dec 01 '18 11:12 hitercs