Le Philousophe
Le Philousophe
I managed to build ScummVM with your patch in dockerized-bb and without this one. I don't see any filtering for these defines inside the winnt.h.
This failed in toolchain image but not worker because in worker we don't set the _WIN32_WINNT version to 0x400. I just pushed a rebased version including @bluegr suggestion. Thanks!
In fact I just noticed that in the buildbot I compiled discord-rpc statically. This change would then break the buildbot.
Do you know what is missing? Does this mean that building statically with discord-rpc makes the binary incompatible with XP?
discord/discord-rpc@b0e31a9e25c556830b3d28319ff994ee3773cf4c added Windows XP support. Maybe that statically link with a mingw version of discord-rpc (what we do) makes it work on XP?
I think these should go in nuked.h instead of our common includes. Some engines also define these types so that would collide. I also propose to reuse our own types...
It seems there have been some mix up in the commits. Could you rebase it properly to only have the last commit?
@digitall it would good to have a review from @elasota
After checking more, I think there is a problem when no framebuffer is used by the backend. In this case, we swap buffer without having drawn anything on screen. Sadly,...
I think I managed to finally fix it without any side effect.