leocad icon indicating copy to clipboard operation
leocad copied to clipboard
verified publisher icon leozide

PATCH: Origin line enhancements

Open rsbx opened this issue 3 years ago • 5 comments

This patch

  1. Adds the Z origin line
  2. Fixes the Z-fighting of origin lines with the base grid
  3. Extends the origin lines past the base grid by 1 grid unit

originlines.diff.txt

rsbx avatar Sep 23 '22 16:09 rsbx

@rsbx you new to GitHub? It would be best to have sent this as a Pull Request instead of a bug report.

hendursaga avatar Sep 27 '22 19:09 hendursaga

@rsbx you new to GitHub? It would be best to have sent this as a Pull Request instead of a bug report.

@hendursaga do you know how to polite?

nathaneltitane avatar Sep 28 '22 16:09 nathaneltitane

@nathaneltitane Yes, I do, and I am. I might've needed to word that differently, but I was offering to help if requested versus letting it disappear down the memory hole.

hendursaga avatar Sep 28 '22 18:09 hendursaga

@rsbx I went ahead and created a PR on your behalf, see https://github.com/leozide/leocad/pull/827. In the future, please do create a Pull Request so that it eases the process. The patch file DID apply without a hiccup, though!

hendursaga avatar Sep 28 '22 19:09 hendursaga

@hendursaga still no pull from @leozide

nathaneltitane avatar May 21 '24 18:05 nathaneltitane