Leonid Tsarev

Results 42 comments of Leonid Tsarev

For me, I think that case ```catch (Exception ex) { log.Error(ex); return false; }``` should not warn. It's pretty common pattern in our code - even this action completely failed,...

Hi! I created PR for this https://github.com/microsoft/winget-pkgs/pull/79060 But winget now can't extract binaries from zip. For winget working, you have either: 1. Publish .exe in release (not zipped .exe) — ...

@Keats hm, I'm not sure, but probably it's something like https://github.com/getzola/zola/pull/1987

Seems that we just could put this on hold. winget soon will be able to extract from zip

superseded by https://github.com/ClosedXML/ClosedXML/pull/1866

Superseded by https://github.com/ClosedXML/ClosedXML/pull/1866

@igitur — not yet. If it's ok, I'll contribute PR on top of #1696 Meanwhile, could you please review and push #1695 & #1696 ?

@igitur what's the plan going forward for #1695 & #1696 ?

Ok, I managed to get .zip working. But here is another issue. https://github.com/microsoft/winget-pkgs/pull/79060#issuecomment-1456455967 zola requires Microsoft.VCRedist.2015+.x64 and if there is some dependency (even so trivial and common), it not considered...

and please assign this issue to me