Leo Torres

Results 188 comments of Leo Torres

Hello @matteocao! The paper has three authors and I see that all three are contributors to the repository. However, there are two contributors that i) are not authors, and ii)...

Thanks for the clarification. I think the current author list makes sense. Do consider to add the names of other/past contributors in the acknowledgements section of the paper.

@matteocao I can see your CI runs pytest on the root directory but wasn't able to find a directory containing a test suite. Could you please point me to it?...

@matteocao I see no mention of related/similar software in the current paper. Are there absolutely no other options for using topological techniques in deep learning?

I have finished my review and I believe the paper can be accepted as is.

@maximelucas This PR addresses #185. Could you please confirm that the proposed solution actually solves the issue to your satisfaction? The old behavior was: ```python3 >>> H.degree? Signature: H.degree(node=None, *args,...

Oh that's a good point. The docstring of `xgi.stats.nodestats.degree` is never really being exposed to the user. The user is not even meant to know that `degree` lives in `xgi.stats.nodestats`....

> How is the equivalence between `H.nodes().degree().asdict()` and `xgi.stats.nodestats.degree(H)` implemented in the code? The short answer is that each NodeStat object is created with a reference to one of the...

> Nice, looks much better. Is this hard-coded copy-paste or you found another clever way? If just copy-pasted, why not just adapt the docs as follows: What I posted is...