grav-plugin-backup-manager icon indicating copy to clipboard operation
grav-plugin-backup-manager copied to clipboard

Some comments

Open Sommerregen opened this issue 8 years ago • 2 comments

Hi @leotiger ,

I really appreciate your plugin and like it :+1: . However, I noticed a few issues, improvements and (minor) bugs.

  • First, what exactly is the difference between test and live mode? Even in test mode I can generate backups.
  • Second, when backing up with the "config" selection, it also saves all Grav root files (robot.txt, .htaccess). I don't know whether this is intended or not, but I found it quite puzlling as "config" usually means all files and folders in user/config.
  • Third, it is possible to automate backups (from admin panel)?
  • Fourth, it would be nice to create backups based on hours, days, weeks, months, and year and set limits to them (i.e, keep 1 backup a day, 7 per week, 4 per month, 3 per year)
  • Fifth, after backing up files you have to reload the page in order to see it in the "Latest backups" widget.

Except of those points (and the access rights you are currently implementing), it is really a nice plugin. Well done!

Sommerregen avatar Jan 26 '17 18:01 Sommerregen

Hi @Sommerregen

  1. If you open a test zip you will see that it only contains the folder structure, same goes for purge requests, you will see how many zips would be deleted but they won't be deleted actually. Only if you run the process using the Live Run Button that shows up on top, the process will be executed.

What's the reason behind? I encountered backup problems with the Grav built-in backup, 50% of the backups did not terminate correctly and this was caused by a lot of libraries I placed in my instance for development purposes. Failed backups left invalid files behind that consumed a lot of space and moreover, nothing showed up in the interface. Summarized: Test mode is useful in two conditions, to fine-tune your backup before turning-off test-mode and as a safe-guard.

  1. Yeah, that's what config is all about. To offer a "support backup". You will also see a phpinfo.html in the backup directory of the zip file.

  2. With CLI you can do that, no problem. CLI offers more options than those exposed in the admin interface. But it would be nice to offer this through admin as well. There are a lot of possibilities to improve here.

  3. CLI is available for this, the rest as in 3.

  4. That's true and that's one of the possible enhancements for the next updates

  5. Access rights are already available in 0.1.2. I fixed the route related problem. You can offer a reduced backup to users with the permission admin.backup-manager. This offers at the moment the possibility to backup media, images and pages to those users.

Regards und Grüsse. u

leotiger avatar Jan 26 '17 18:01 leotiger

@Sommerregen

I updated the plugin. Version 0.1.3 includes some bug fixes and minor improvements.

leotiger avatar Jan 26 '17 22:01 leotiger