joypy icon indicating copy to clipboard operation
joypy copied to clipboard
verified publisher icon leotac

using the bottommost axes as the last axes instance

Open K20shores opened this issue 4 years ago • 5 comments

This allows issue #60 to to be resolved. I am unaware of the consequences of this, though.

K20shores avatar Jul 22 '21 17:07 K20shores

This is the image generated with the same code in #60 using the patch I submitted in this PR, for your reference (with some added styling of the right hand figure).

image

K20shores avatar Jul 22 '21 18:07 K20shores

Two of the tests in the python notebook fail:

  1. The first one that shows the grid. The bottom grid is drawn correctly, but the grids above that are drawn on top of the data. I am working on that
  2. The Unknown Pleasures album cover is not being displayed. I am not sure why. I will look into that after I figure out the grid.

If you happen to want to accept this as a PR and have any insight, please let me know.

K20shores avatar Jul 22 '21 22:07 K20shores

Hey! Thanks for the contribution. I'll take a look when I have the chance.

leotac avatar Jul 23 '21 16:07 leotac

There are still some outlying problems:

  1. The Unknown Pleasures example, for some reason, is not rendering in the notebook for me.
  2. Grid lines in density estimate plots overlay the density estimate. That is not true for histograms.

I am looking into both.

K20shores avatar Jul 27 '21 15:07 K20shores

Well, I figured out the Unknown Pleasures issue, all that's left is the grid zorder issue.

K20shores avatar Jul 27 '21 16:07 K20shores