rules_reason icon indicating copy to clipboard operation
rules_reason copied to clipboard

Example out of date?

Open joprice opened this issue 7 years ago • 1 comments

Looks like the opam_package rule added a new argument, 'type', which is missing. It also seems like the available types won't support the format that cmdliner uses: tbz.

11:14 $ cd examples && bazel build ...
Starting local Bazel server and connecting to it...
...........
ERROR: /Users/josephprice/dev/github.com/ostera/rules_reason/examples/3rdparty/opam/deps.bzl:8:5: //external:opam.cmdliner: missing value for mandatory attribute 'type' in 'opam_package' rule
ERROR: /Users/josephprice/dev/github.com/ostera/rules_reason/examples/3rdparty/opam/deps.bzl:8:5: //external:opam.cmdliner: invalid value in 'type' attribute: has to be one of 'zip', 'jar', 'war', 'tar.gz', 'tgz', 'tar.bz2' or 'tar.xz' instead of ''
ERROR: error loading package 'external': Package 'external' contains errors
INFO: Elapsed time: 0.622s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (0 packages loaded)

joprice avatar Sep 24 '18 15:09 joprice

The example must have gone out of the date when I started working more heavily on retool. I had to do a lot of changes to the main rules and I was focused on getting that project to build and run.

It should be updated tho!

leostera avatar Sep 25 '18 11:09 leostera