Leo Shklovskii
Leo Shklovskii
And they're still `node.exe`, right?
Ouch. That's really frustrating. Nice find @lloiser. The readme for that repo says to file issues in `facebook/nuclide`. Maybe file it there instead?
I'm loosely against that. I don't know if flow's word boundaries are the same as Atom's - it also doesn't give you the underlining feedback of whether something *is* clickable....
@steelbrain - My initial theory is that https://github.com/steelbrain/flow-ide/blob/master/lib/index.js#L58 won't find a `flow.exe` file, which triggers a more expensive invocation of flow that goes through `node.exe`. I need to dust off...
Confirmed. `flow.exe` is lightning fast, invoking it via `node.exe` can take a second. @steelbrain can you reopen #103 and close this? Or create a new issue to track this work...
Here's the issue that got filed with flow - https://github.com/facebook/flow/issues/4445 - they haven't responded (possibly because it's closed) so maybe open up a new one with the same question?
Pushing the PR that changes search path order should allow folks to workaround the issue by invoking `flow.exe` explicitly.
I can try that, but it's a bit concerning that CI doesn't test this - it's running under 3.10 for at least one of the runs. Is it possible that...
Thanks for the fix! Also, should we be using `unittest` or `pytest` to run the test suite? `pytest` is clearly being installed in `requirements-test.txt` and being used by `test-python-package.yml` but...
Any updates with this? Running into the same issue.