nodecloud-cli icon indicating copy to clipboard operation
nodecloud-cli copied to clipboard

Add more unit tests for Storage and Network

Open TRomesh opened this issue 6 years ago • 2 comments

  • Follow the same pattern used in the existing unit tests

TRomesh avatar Sep 05 '19 03:09 TRomesh

Hi, I just want to be clear about the task. The goal of the task is creating unit tests for others providers, gcp and azure, for storage and network services. So basically, I have to add more test in storage.test.js and network.test.js and create Gcpmock.js and Azuremock.js file for those tests. Please tell me whether I am mistaken.

duc0905 avatar Dec 08 '19 16:12 duc0905

Hi, I just want to be clear about the task. The goal of the task is creating unit tests for others providers, gcp and azure, for storage and network services. So basically, I have to add more test in storage.test.js and network.test.js and create Gcpmock.js and Azuremock.js file for those tests. Please tell me whether I am mistaken.

@duc0905 Yes you can create mock files and write tests. You can write more test for network.test.js by looking for the methods which has no test written under network.js. i.e
network.test.js has only 4 tests but network.js has more methods, Write test for the reaming methods.

TRomesh avatar Dec 08 '19 17:12 TRomesh