Leon Löchner

icon location Berlin icon location Finished studying computer science at HWR Berlin.

Results 27 comments of Leon Löchner

Add option for minimal reboot period

Can I do anything about the failing e2e tests?

testutil compareMetricFamilies: make less error-prone

According to Contributing.md I have to address one of the maintainers: @bwplotka I also tried using table tests as you suggested in #1351, but I found it a bit messy...

testutil compareMetricFamilies: make less error-prone

@bwplotka thanks for your review. I hope I addressed all you comments

testutil compareMetricFamilies: make less error-prone

@bwplotka anything missing from my side to move on with this PR?

TF_PLUGIN_CACHE_DIR is not present in custom steps

Hi [Dosu](https://dosu.dev/), you are right, that the DefaultClient propagates the `TF_PLUGIN_CACHE_DIR`. However when using a custom step, the atlantis `TerraformExec` is not used and its `RunCommandWithVersion` does the injection of...

TF_PLUGIN_CACHE_DIR is not present in custom steps

> I mean the fix is easy by providing an extra EnvStepRunner I solved it in a similar way. I opened the issue not because it is not possible, but...

Add cache-primary-key and cache-matched-key outputs to actions/cache

~Yes please, at the moment the README has examples that use the cache-primary-key output and they don't work.~ EDIT: I missed that the examples were using `actions/cache/restore` which does output...