Photok icon indicating copy to clipboard operation
Photok copied to clipboard

Find replacement for com.ortiz.touchview.TouchImageView

Open leonlatsch opened this issue 4 months ago • 1 comments

com.ortiz.touchview.TouchImageView seems to cause about half of the crashes in the app. We should find a replacement for it.

Maybe use a compose library and rewrite the image viewer in compose next.

If you know good libraries, please comment them down below.

leonlatsch avatar Feb 15 '24 16:02 leonlatsch

Maybe fixed by #256.

Lets see till after next release

leonlatsch avatar Feb 21 '24 07:02 leonlatsch

Seems fine for now. Will use something else once the image viewer will be rewritten in compose

leonlatsch avatar Mar 11 '24 12:03 leonlatsch

According to google play this library still caused about 50% of the crashes, even after the update.

We might need to replace it before rewriting the image viewer in compose

leonlatsch avatar Apr 26 '24 09:04 leonlatsch

In compose there is https://github.com/saket/telephoto This might be a good solution. Or I could implement a custom modifier. That is also a good lightweight solution without a third party library.

Maybe its a good idea to do this before a rewrite and just replace the image view inside with a compose image view

leonlatsch avatar Apr 30 '24 13:04 leonlatsch