Export not working properly

[jerryn70]

I have 2199 files in photok gallery both images and videos . When I select all files and try to export it to the gallery only 799 images is exported

[leonlatsch]

@jerryn70 if you select all, are really all of them selected?

If not, this could be a bug related to paging.

[jerryn70]

@leonlatsch all files are selected. I scrolled through all the files and confirmed.

[leonlatsch]

@jerryn70 is the exporting dialog displaying the right amount of photos?

Eg: Exporting: 1/2199

Or is it displaying: 1/799

[leonlatsch]

@jerryn70 the configured max for photos loaded at once is 800.

This would match pretty well 🤔

[jerryn70]

@leonlatsch 1/799

[leonlatsch]

@jerryn70 Well, ok.

I will Label this a bug and fix it once I find the time.

As a workaround:

• Select all
• export
• Scroll down
• Export again

This should work, I guess.

[jerryn70]

@leonlatsch i tried this but it creates too many duplicate file exports.

[jerryn70]

@leonlatsch Another export error in the latest fdroid version. It shows finished but nothing is exported to the gallery.

[leonlatsch]

The Problem

The multi selection is index based.

When selecting all, the item count is used to add all items. The item count also includes all placeholders, added by paging.

So the placeholders are selected, but no item lays behind them. Therefore they cannot be used.

[leonlatsch]

We may think about dropping paging, since the data that is currently loaded paged, is not big. Loading the thumbnails happens in the ViewHolder's onBind anyway. What do you think? @comparesheriff

[SeleDreams]

This issue is still present for me

[leonlatsch]

I know, sorry about that.

This is a complex issue wich involves rewriting a bug chunk of logic and Photok is currently just maintained.